Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix sync comment in observer example #41262

Merged
merged 1 commit into from Dec 27, 2021
Merged

doc: fix sync comment in observer example #41262

merged 1 commit into from Dec 27, 2021

Conversation

erj826
Copy link
Contributor

@erj826 erj826 commented Dec 21, 2021

Updates doc comment here since the PerformanceObserver callback is always called asynchronously.

Refs: #41259

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. labels Dec 21, 2021
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 21, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

@erj826
Copy link
Contributor Author

erj826 commented Dec 27, 2021

Anything else I need to do to get this across the finish line?

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 27, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 27, 2021
@nodejs-github-bot nodejs-github-bot merged commit d34fcb6 into nodejs:master Dec 27, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in d34fcb6

targos pushed a commit that referenced this pull request Jan 14, 2022
@erj826 @targos
doc: fix sync comment in observer snippet
5cfc547 
PR-URL: #41262
Refs: #41259
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@targos targos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@erj826 @danielleadams
doc: fix sync comment in observer snippet
cc4df85 
PR-URL: #41262
Refs: #41259
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@erj826 @Linkgoron
doc: fix sync comment in observer snippet
eb007ab 
PR-URL: nodejs#41262
Refs: nodejs#41259
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@erj826 @danielleadams
doc: fix sync comment in observer snippet
1c0c140 
PR-URL: #41262
Refs: #41259
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@HarshithaKP HarshithaKP HarshithaKP approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@erj826 @nodejs-github-bot @jasnell @lpinca @HarshithaKP @VoltrexKeyva